670985 - download Save button not always in focus

Status: RESOLVED WONTFIX

(Firefox :: General, defect)

Description

[Derek Williams]

Attachment: Screen shot 2011-07-12 at 18.31.18.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110615151330

Steps to reproduce:

@ http://www.gsmd.ac.uk/about_the_school/about_us/job_vacancies.html clicked a link:
http://www.gsmd.ac.uk/fileadmin/user_upload/files/Job_Vacancy_info/Information_Pack_-_GS100.pdf   I chose Save to a location.  This brought up a file browser, with the Save button highlighted as blue.  I browsed to where I wanted it to go, and saved the file.

I then clicked the second link:
http://www.gsmd.ac.uk/fileadmin/user_upload/files/Job_Vacancy_info/GS100_GSMD_Application_Form.doc


Actual results:

The first time the "Opening [filename]" appeared offering "Open with [application]" or "Save file".  When Save file was chosen, the Save button was highlighted as blue.

The second link went straight to the Save file browser, however the Save button was no longer highlighted as blue.  If I pressed Enter, nothing happened,  however I later found that after saving the file to the above location, the "Opening [filename]" dialog reappeared, even though I had already saved it.


Expected results:

The Save button should always highlight blue as default, so one can save a succession of downloads to the same location as previously.  Its present behaviour means that this has to be done manually each and ever time.  In earlier versions of Firefox, this did not happen, one was able to select a location the first time and then have the browser automatically return to the same browsed-to location thereafter unless changed, in whcih case it would subsequently return to the new browsed-to location, with Save button highlighted as blue and thus activatable by a simple press of Enter as previously.

Comment 1

[Derek Williams]

Attachment: Browser showing Save button enabled

Comment 2

[Derek Williams]

Attachment: Browser showing Save button inactive

Comment 3

[Vlad [QA]]

The second link, with the pdf doesn't work.

Comment 4

[Derek Williams]

It opens in MS Word.

Comment 5

[Vlad [QA]]

Reporter, does the issue is still reproducing on the latest Firefox beta:
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/6.0b5/mac/en-US/

Comment 6

[Derek Williams]

Attachment: Save button not in focus

Have tried just now under Firefox 7.0 with the Shockwave Updater, and as you can see from this image attached the Save button is not enabled, so one cannot press Enter to automatically start the download.  A mouse click is needed first to bring Save into focus and then again (or Enter, once in focus) to initiate the download.

Comment 7

[Vlad [QA]]

Reporter do you have anything new regarding this issue?
Thanks.

Comment 8

[Derek Williams]

This issue is not changed by beta 8.

Comment 9

[Vlad [QA]]

Attachment: screenshot

When I load the second link in the url, I get another pannel in wich I got only the 'ok' or 'cancel' options like in the attachment.

The first link from the description is behaving as described: the save button is always highlighted. (even though I got a smaller pannel - see screenshot2)

The same behavior is applied to:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0) Gecko/20100101 Firefox/8.0b4 and
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a1) Gecko/20111024 Firefox/10.0a1

Comment 10

[Vlad [QA]]

Attachment: screenshot2

Comment 11

[Derek Williams]

The issues occurs when there is first a choice to Save or Open, as in above example at https://bug670985.bugzilla.mozilla.org/attachment.cgi?id=545410

After that, the Browse window is not in focus, as at https://bug670985.bugzilla.mozilla.org/attachment.cgi?id=545413

If the download goes straight to the Browse window, then it is in focus as in your example.

Comment 12

[Derek Williams]

Attachment: Step 1 - Choose to download a file by Save

Steps to reproduce:

Step 1
Select for download from a website, a file that offers the choice either to be Opened by an app, or Saved As...

Comment 13

[Derek Williams]

Attachment: Step 2 - After Save As selected, file browser is out of focus

Step 2:
Because the file browser is out of focus, if one presses Enter at this, the file does not Save, but instead tries to save another copy after the current one has been saved.

Comment 14

[Derek Williams]

Attachment: Step 3 - Click on any part of the file browser to bring Save into focus

Step 3:
Once the file browser has been clicked on, one can safely press Enter because the Save button is now in focus.

Recommendation:  Make the Save button in focus by default so Enter can be pressed straight away to save the file to the desired destination.

Comment 15

[Derek Williams]

This bug is still present.

Comment 16

[Frankie]

Derek Williams, you are cheating.

As easily observed by the color state of the OS X window controls (aka the jelly beans), the Save button becomes gray only when the entire Firefox application is in the background, and another application has focus. This is the correct behavior, because it indicates that key presses will not be received by the save dialog window while it is backgrounded.

This bug should be closed as invalid.

Comment 17

[Derek Williams]

Sorry that is not true.  "Cheating"?  That is quite an affront.

When I save a Download, Thunderbird is in the foreground.  The Save button is not enabled by default almost every time.  Indeed the Save window is not in the foreground, not because I have navigated elsewhere so as to put Firefox into the background, but because Firefox itself has put the Save dialog into its own background.

I wouldn't waste everyone's time with this if it were not so annoying, and persistent.

Comment 18

[Frankie]

I apologize. I have replicated the problem you describe. 

Your description leaves out a couple necessary details:

1: in Firefox Preferences -> General, Downloads must be set to "Always ask". If you have a specified destination to Save files, the error will not happen.

2: in Firefox Preferences -> Applications, the content type's action must be set to "Always Ask". If the action is set to "Save File" or to Use a particular application, the error will not happen.

If you load a file type that goes to the "What should Firefox do with this file?" dialog (as in the first screen shot), then choose Save and click OK, the following Save dialog will display as backgrounded. It seems like the focus failure occurs during the handoff between the two dialogs.

Comment 19

[Derek Williams]

That's right Frankie. It was so long ago that I set that preference I had forgotten having done so.  I suppose some people would just default to the Downloads folder, whereas I always want to point files to their target destination so as not to waste time moving them afterwards.

Good to hear you've reproduced it at last, and that it's made it into the queue.